Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of NPC Dialogues #666

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Implementation of NPC Dialogues #666

wants to merge 9 commits into from

Conversation

abimek
Copy link
Contributor

@abimek abimek commented Sep 8, 2022

Decided to make a new api instead of using the forms api, more flexible in the future.

@JustTalDevelops JustTalDevelops added the feature New feature or request label Oct 23, 2022
Flonja
Flonja suggested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@Flonja Flonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes

server/player/dialogue/button_type.go Outdated Show resolved Hide resolved
server/player/dialogue/menu.go Outdated Show resolved Hide resolved
server/player/dialogue/menu.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
T14Raptor
T14Raptor reviewed Feb 6, 2023
View reviewed changes
server/session/player.go Outdated Show resolved Hide resolved
T14Raptor
T14Raptor reviewed Feb 6, 2023
View reviewed changes
server/session/player.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T14Raptor T14Raptor T14Raptor left review comments

@unickorn unickorn unickorn left review comments

@Flonja Flonja Flonja requested changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abimek @Flonja @unickorn @T14Raptor @JustTalDevelops